@vanzasetia
Posted
Hello there! 👋
Good effort on this challenge! 👍
Some suggestions from me.
- I recommend swapping all
article
andsection
withdiv
elements. If you see the HTML issues that has been reported,article
andsection
cause some issues. It's okay to usediv
as long as it doesn't cause any accessibility issues. - You can read this article about
div
, written by Scott O'Hara. It will tell you when and how to use adiv
. Also, it might change the way you think aboutdiv
. - For the white space, I suggest using
margin
orpadding
instead ofnbsp
. - All elements that have interactivity should be wrapped by interactive elements like anchor tags.
- Those icons are decorative images which means that if they don't exist, there will be no missing information, it's just made the site looks less pretty. So, for decorative images leave the
alt
empty. - Alternative text for images should not contain the word "icon" or any words that are related to "image".
- Alternative text for the avatar should be the author's name.
That's it! Hope this helps.
Marked as helpful
@KohseyPower
Posted
@vanzasetia Hello !! I am grateful to you for detailing my mistakes. I will correct my 'alt' things and my not really sexy 'nbsp'. However, I have a last question. Should I replace my equilibrium interactive image by an anchor tag ? Thanks in advance for answering.
Right after posting this, I will go to your link about 'div'.
Have a nice day ! 😘
@vanzasetia
Posted
@KohseyPower Hahaha, you're welcome! 👍
You should replace the section
tag with an anchor tag. That's what I mean. 🙂
@KohseyPower
Posted
@vanzasetia Okay got it!