Design comparison
Solution retrospective
I would be grateful if you point out my mistakes.... Your feedback may help me out hence all feedback are welcome.../
Community feedback
- @MelvinAguilarPosted about 2 years ago
- Try to use semantic tags in your code. More information here:
With semantic tags:
<body> <main class="bg"> . . . </main> <body>
- You can directly use the <a> element, instead of:
<p class="cancel"> <a href="index.html">Cancel Order</a> </p>
Use:
<a href="index.html" class="cancel">Cancel Order</a>
And update the .cancel selector:
.cancel { font-weight: 700; display: block; margin-block: 1em; }
The same concept of directly using the anchor element on the
<a href="#" class="change">Change</a>
I hope those tips will help you.
Good Job and happy coding !
Marked as helpful0@hkalita20Posted about 2 years ago@MelvinAguilar I am sure to keep this on mind for the next time.... Thank you for your helpful comment...
1 - @im-abhijitPosted about 2 years ago
hi @hkalita20 , congratulations on completing this challenge , you have done a good job
please do use min-height for your container element else your content will get cropped
test your code on width 300px and height 400px you will see your image is getting cropped
you can check my solution to get an idea
https://www.frontendmentor.io/solutions/stats-preview-card-component-solution-with-mobile-first-methodology-S9nVoXkiRg
0@hkalita20Posted about 2 years ago@im-abhijit okay I will keep it on my mind for the next time m really grateful to your advice. Hope so you would be helping me out by preferring the best for my development...
Thanks...
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord