Hi there 👋, I’m Loai and this is my solution for this challenge. 🚀

Community feedback

• 

  Pipow•500

  @PipouwPieuwPosted over 1 year ago

  Hello Loai, good job completing this challenge!

  Your page looks good :) Here are a few suggestions to further improve it:

  • Instead of using 2 images for desktop and mobile and hiding them with CSS, you should look into the picture tag. It is very helpful once you know how to use it!
  • I wouldn't set a fixed height to the card because you'd want it to adapt to its content. Imagine having to write a longer text inside, then the card should be able to expand.
  • I don't think perfume image is a good alt attribute. Think of how you would describe the image to someone that can't see it. For exemple A bottle of Gabielle Essence Eau De Pafum lying between two leaf branches.

  Overall I think you did well, and the mobile version looks neat too! Good work :)

  Marked as helpful

  1

  ---

  

  Loai Esam•670

  @LoaiEsam37Posted over 1 year ago

  @PipouwPieuw Thank you for the Feedback ❤️

  0