HDWD

Community feedback

• 

  P

  visualdennis•8,375

  @visualdennissPosted over 1 year ago

  Good job on completing the challenge and implementing the logic! Overall it works, but there could be some improvement. To answer your question:

  you can add external js file to your html by adding before </body>.

  I'd also say try to avoid having the result in a new page like so: newWindow.document.write("<h1>Thank you for your rating!</h1>"); newWindow.document.write("<p>" + selectedText + "</p>");

  But instead try to update the DOM by rendering new state of values. e.g. you can use Element.innerHTML = "..." https://developer.mozilla.org/en-US/docs/Web/API/Element/innerHTML for that etc.

  Hope this was helpful!

  0
• 

  Bentaher malek•730

  @malek-btPosted over 1 year ago

  Hey !, how are you ? I really liked the result of your project, but I have some tips that I think you will enjoy:

  1.To center the <div class="box">, you can use grid like: display:grid;place-items: center; or you can use flexbox like this: display:flex;justify-content: center;align-items: center.

  2.Implement the mobile first approach.

  3.Instead of using pixels in font size, use relative units of measure like rem or em. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers.

  The rest is good, I hope those tips will help you! 👍

  0