grid-template-columns and repeat and minmax function
Design comparison
Solution retrospective
This challenge was fun! Pls give your review of my site and whether the job was up to the mark or not. Any improvements on my code are appreciated. TIA
Community feedback
- @GerbenDolPosted over 4 years ago
Hey! Your solution is looking great, nice job! π
Maybe change:
- give the cards a border radius, so also on the bottom corners
- Add a hover effect to your cards
- Add a hover effect (at least
cursor: pointer;
to your dark mode switch)
Thanks for submitting your great solution! π
1@sarvagya2545Posted over 4 years ago@GerbenDol Oh noo! I forgot about the hover effects completely! My Bad lol
0@sarvagya2545Posted over 4 years ago@GerbenDol So I added the hover effects, but the
cursor:pointer;
is not happening in the frontendmentor site whereas on my system it is happening. Is it normal?0@GerbenDolPosted over 4 years ago@sarvagya2545 Maybe its cache? It's working for me, looking good! π
1@sarvagya2545Posted over 4 years ago@GerbenDol Yeah it works! Looks like it was cache. Thanks for your feedback!
0 - @rcarlosalbaPosted over 4 years ago
well done! Everything works well!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord