Design comparison
SolutionDesign
Solution retrospective
Was that a challenge! I would love to hear your thoughts on this one. I probably made the code more complicated than necessary. Thank you in advance!
Community feedback
- @ApplePieGiraffePosted over 3 years ago
Hi, Aleksandra Ryan! 👋
Well done on this challenge! 👍
A few things I suggest are,
- Adding a max-width to the main container or wrapper of the page (such as
div.container
) and centering it in the viewport so that the layout of the page doesn't become too wide and the elements seem too spaced out on extra-large desktop screens. - Since you are adding more than one background image to the
body
in this challenge, I would suggest separating your background properties in your CSS (rather than try to fit many values into the singlebackground
property). This will make your styles easier for you and others to read and manage and should help with troubleshooting some issues (such as one of the background images repeating in the desktop layout of the page). - Rather than using absolute positioning to place the review boxes in the desktop layout, I think you can stick them to being placed by their flex container and simply using the
transform
property to align them differently instead. 😉
Keep coding (and happy coding, too)! 😁
Marked as helpful0 - Adding a max-width to the main container or wrapper of the page (such as
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord