Design comparison
Solution retrospective
What's most important to me is to know if the way I implemented the mobile responsiveness is the right way to do so? As I needed to 'reconfigure' the grid I am wondering if I'm mistaken and the grid should be responsive by itself as that is one of the functionalities of the grid.
Community feedback
- @InterplanetaryDragonPosted over 4 years ago
Hi Frederick, site looks good. I tried to check the code to see what the errors are (2 accessibility and 4 HTML) but the code seems to be for a different design.
It looks like the errors are saying you have used the same ID more than once. You cannot use the same ID more than once. IDs are individual, therefore if you are going to use it more than once you should create a class. Here is a good link: https://css-tricks.com/the-difference-between-id-and-class/
Only thing U can see visually which you could improve is using font weight 200 for the heading 'Reliable, efficient delivery', as the current font-weight is too heavy.
If you want to learn more about CSS Grid I recommend this video and code to go with it:
https://www.youtube.com/watch?v=7kVeCqQCxlk https://codepen.io/mor10/pen/NjeqyX/
Also, check out this short and free course. It has some useful tips: https://scrimba.com/playlist/pWqLHa
Good job!
1 - @MeFredjPosted over 4 years ago
Hi InterplanetaryDragon,
Thank you so much for your valuable feedback. I've mixed up the links of my repositories. The correct link should be available now. Is there any chance you could have a look at my code? I am aware of the fact that I used two ID's which I shouldn't. Won't make that mistake again.
Hope to hear from you soon!
Thanks once again :)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord