Marcos Travagliniā¢ 4,920
@Blackpachamame
Posted
Greetings! you have done a great job š
š Some accessibility and semantics recommendations for your HTML
- To improve the semantics of your HTML, you can change your
<div class="attribution">to a<footer class="attribution"> - I don't think the
addresstag is appropriate for this case since it is not an address, but rather the name of a person - Definitely a title should not go inside a
header, for this you have headers likeh1,h2, etc.
š Some suggestions
- You can use
gridin thebodyto center your content:
body {
font-family: 'Barlow Semi Condensed', sans-serif;
display: grid;
place-content: center;
min-height: 100vh;
}
Marked as helpful
1
turanaricanā¢ 200
@turanarican2022
Posted
Hey @Blackpachamame thank you. I took them into consideration, but as per using the <address> tag for info about an author of the nearest ancestor <article> is not a bad idea as I understood from MDN docs.
For reference; https://developer.mozilla.org/en-US/docs/Learn/HTML/Introduction_to_HTML/Advanced_text_formatting#marking_up_contact_details
0
Marcos Travagliniā¢ 4,920
@Blackpachamame
Posted
@turanarican2022 It's true, it's somewhat confusing, I interpret it as being used to specify a contact address, I think it makes more sense. But it's up to each one how they interpret it.
0
