Grid testimonials section

Community feedback

• 

  Marcos Travaglini•4,840

  @BlackpachamamePosted 10 months ago

  Greetings! you have done a great job 😎

  📌 Some accessibility and semantics recommendations for your HTML

  • To improve the semantics of your HTML, you can change your <div class="attribution"> to a <footer class="attribution">
  • I don't think the address tag is appropriate for this case since it is not an address, but rather the name of a person
  • Definitely a title should not go inside a header, for this you have headers like h1, h2, etc.

  📌 Some suggestions

  • You can use grid in the body to center your content:

  body {
      font-family: 'Barlow Semi Condensed', sans-serif;
      display: grid;
      place-content: center;
      min-height: 100vh;
  }
  

  Marked as helpful

  1

  ---

  

  turanarican•200

  @turanarican2022Posted 10 months ago

  Hey @Blackpachamame thank you. I took them into consideration, but as per using the <address> tag for info about an author of the nearest ancestor <article> is not a bad idea as I understood from MDN docs.

  For reference; https://developer.mozilla.org/en-US/docs/Learn/HTML/Introduction_to_HTML/Advanced_text_formatting#marking_up_contact_details

  0

  

  Marcos Travaglini•4,840

  @BlackpachamamePosted 10 months ago

  @turanarican2022 It's true, it's somewhat confusing, I interpret it as being used to specify a contact address, I think it makes more sense. But it's up to each one how they interpret it.

  0