grid testimonial with regular html and stuff.

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello @bakemonostan, congratulations on your new solution!

  I’ve some suggestions for you:

  1.You've missed the color for the background, in this case is background-color: #EDF2F8 and add it to the body.

  2.You’re in the right track I can see that you’ve used the majority semantic tags possible for this challenge, the only block you’ve missed is the paragraph containing the quote text you can improve the accessibility there using <blockquote> to indicate to screen readers that the content inside that paragraph is a quote.

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  Ehiz Omokhomion•150

  @bakemonostanPosted about 2 years ago

  @correlucas yeah, it does. Thanks. I worked on this challenge a while ago, just got around to submitting it. Sadly I did not go through the code before submitting, kinda felt lazy.

  Thank you so much for the feedback

  0
• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • Your component is warping vertically, this needs fixing.

  • The Article Element is not the best choice for wrapping these testimonials. In order to use the Article Element the component needs to be able to make sense on its own and is independently distributable (can be used in on another site). These testimonials cannot do neither.

  • Instead, you want to wrap each individual testimonial component in a Figure Element, the individuals information should be wrapped in a Figcaption Element and lastly, the testimonial itself should be wrapped in a Blockquote Element.

  Code:

  <figure>
     <figcaption></figcaption>
     <blockquote></blockquote>
  </figure>
  

  More Info:

  ARTICLE

  • The profile images Alt Tags need to be improved. It should state the following; “Headshot of -person’s full name-“

  • The only headings in this component are the names of each individual; “Daniel Clifford”, “Jonathan Walters”, “Jeanette Harmon”, “Patrick Abrams” and “Kira Whittle”. Everything else should be wrapped in a Paragraph Element.

  If you have any questions or need further clarification, let me know.

  Happy Coding! 👻🎃

  0