GRID template Area Flex

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hello @TheXilot, congratulations on your new solution!

  I’ve some suggestions for you:

  Your html is working but you can improve it using meaningful tags and replace the divs, for example the main div that takes all the content can be wrapped with <main> or section, about the cards you can replace the <div> that wraps each card with <article> you can wrap the paragraph with the quote with the tag <blockquote> this way you'll wrap each block of element with the best tag in this situation. Note that <div> is only a block element without meaning, prefer to use it for small blocks of content.

  This article from Freecodecamp explains the main HTML semantic TAGS: https://www.freecodecamp.org/news/semantic-html5-elements/

  The box-shadow is a bit too strong, this is due the opacity and blur. The secret to create a perfect and smooth shadow is to have low values for opacity and increase blur try this value instead: box-shadow: 12px 7px 20px 6px rgb(57 75 84 / 8%);

  If you’re not familiar to box-shadow you can use this site to create the shadow design and then just drop the code into the CSS: https://html-css-js.com/css/generator/box-shadow/

  ✌️ I hope this helps you and happy coding!

  0
• 

  Tertsegha Kpughur-Tule Moses•210

  @Mosestule2003Posted about 2 years ago

  Hey man I really love your work well done. Although they are a few things that I think can help improve your solution.

  • Instead of setting the box-shadow on each grid-item, try setting the box-shadow on the parent grid-container. Also i think a box-shadow of something like (box-shadow: 10px 5px 10px grey;) will work with a lighter grey color.

  • Also to best center the grid-content on display, try setting up the body element with: #display: flex; #align-items: center; #justify-content: space-between; This will help center your content much better. Tell me if this helped, Happy coding bro :)

  0