grid system

Community feedback

• 

  P

  Marcus•120

  @marcus-hillPosted about 1 month ago

  Hi Kaleb, I'm unable to access your Github Repo (perhaps it isn't public?), however I can provide some feedback based on your live preview link and the dev tools:

  • Good start with the mobile design first, I can see this is where you've put your effort and began with mobile design, which is best practice.
  • Good use of some semantic HTML, however I think you could have used more, such as the <article> tag and also the <section> tag.
  • On a desktop, your solution does not meet the design and is far too wide, extending nearly to the left and right hand side of my screen. Whilst it works on a smaller screen size (of 1000px), it begins to get far too big on anything larger. From looking at the dev tools, there doesn't appear to be a max-width set on the .total class div, which is causing it to grow and grow in size until the content is stretched way beyond necessary.

  Keep up the good work and I am sure this will be much better with a few changes.

  0