Grid sectoin

Community feedback

• 

  Muqtadeer•340

  @hashmi7917Posted about 2 years ago

  hi Omaima, i have some suggestions for you here it is. firstly dont give grid column n rows in fixed pixels , alternatively you can give "fr" ex: repeat(4, 1fr). by using pixels u cant get responsive design.

  0

  ---

  

  Omaima Rababaa•40

  @omaimarababaaPosted about 2 years ago

  @hashmi7917, Thanks for your suggestion I'll implement this.

  0
• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • To center you content to your page, add the following to your Body Element:

  body {
      min-height: 100vh;
      display: grid;
      place-content: center;
  }
  

  • To better specify the main content of you site you will want to encase your entire component inside a Main Element.

  • The **names of each individual are headings so they should be wrapped in a Heading Element.

  • To enhance the semantics of your component, you want to wrap each individual testimonial component in a Figure Element, the individuals information should be wrapped in a Figcaption Element and lastly, the testimonial itself should be wrapped in a Blockquote Element.

  Code:

  <figure>
     <figcaption></figcaption>
     <blockquote></blockquote>
  </figure>
  

  More Info:

  ARTICLE

  If you have any questions or need further clarification, let me know.

  Happy Coding! 👻🎃

  0

  ---

  

  Omaima Rababaa•40

  @omaimarababaaPosted about 2 years ago

  @vcarames, Thanks for your suggestions I'll implement this.

  0