Grid section responsive with sass and BEM

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted about 3 years ago

  Hell

  This looks good overall but there are some improvements to suggest

  • heading levels should be increased. They should only be h3 if there is a h2 above them in each article
  • verified graduate is not a heading. Try paragraph with small tag
  • maybe consider using figure, figcaption and blockquote elements for this. That’s a recommended approach for testimonials
  • important: Never put font sizes in px, use rem (or em sometimes)
  • consider converting all pixel units to REM. Then if users have different zoom/base font settings all will scale together
  • Don’t forget small design details like the box shadow on white bg boxes
  • There is loads of repetition in the css. See if you can create some more reusable classes for all the shared styles. All the individual boxes need is a color class and a grid area (grid area can also be done with nth of type / nth child, but having unique classes is ok for grid placement if you prefer)

  Good luck

  0

  ---

  

  Leobardo Núñez•110

  @LenugoPosted about 3 years ago

  @grace-snow Thanks for the feedback, I'll apply the improvements

  0