Design comparison
Solution retrospective
hello every one , this my first challenge on frontend mentor and it wasn't difficult i was enjoying while working on it . i would like ask professionals users about best practices and how to get a solid knowledge while practicing.
Community feedback
- @DaFlusherPosted 12 months ago
Nice job Muraddevp! It looks great. I just have a few suggestions : 1)adding semantic html like 'main' as a wrapper after the body element, instead of a div. 2)Using relative units for padding,font-sizes, 13px = 0.8125em/rem. 3) Not setting absolute values for grid template rows, I personally think using grid-auto-row: minmax(); is more responsive. 4)Finally, from my end, at a screen-width of 767px, the elements at the edge were clipped, maybe try increasing it to 1200px or more. Well done and goodluck!
1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord