Design comparison
SolutionDesign
Solution retrospective
any feedback on the layout on how i can improve my code is welcome :)
Community feedback
- @Shivraj-K09Posted over 1 year ago
Based on the code, here is my feedback:
- Great use of semantic HTML. You have used appropriate tags such as
nav
,ul
, andpicture
which makes your code easier to read and understand. - Your CSS code is structured well and easy to read. You have used appropriate class names and have grouped related styles together.
- Use of media queries for responsiveness is great. However, in some cases, you are relying on fixed values such as
min-width: 600px
which might not work well across different devices. It's a good idea to use relative values such asem
or%
to ensure consistency across devices. - Consider reducing the number of
font sizes
used in your code. Having too many font sizes can make your code harder to read and maintain. Try to group related font styles together and use CSS selectors to apply them to different elements.
Overall, great job on your code and keep up the good work! Happy Coding 😉🫡
Marked as helpful1 - Great use of semantic HTML. You have used appropriate tags such as
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord