Design comparison
Solution retrospective
Any advice of how i improve my code?
Community feedback
- @vanzasetiaPosted over 2 years ago
Hello there, @iagohenrique2009! 👋
Good effort on this challenge! 👍
However, based on the design comparison the background color for the
body
element is different. So, I recommend changing the color. If the color doesn't exist on thestyle-guide.md
you can try copy-paste the color code from other solutions.I would recommend adding some
padding
on thebody
element because on mobile view (both landscape and portrait) the card is filling the entire screen.I think the "Sign up" button should be a link instead of
button
because as a user I would expect after I click the button, it will navigate me to the Sign-up page. So, what do you think is going to happen after you click the button? Regardless, every time you use thebutton
element, you should always specify thetype
of thebutton
to prevent it from behaving unexpectedly.Lastly, it's worth fixing all the issues that have been reported by Frontend Mentor, especially the invalid HTML.
I hope you find this information useful!
Marked as helpful2@vanzasetiaPosted over 2 years agoI couldn't remember it clearly but, have I given some feedback to you before?
1@iagohenrique2009Posted over 2 years ago@vanzasetia Hi friend!
Yes you has given me feedback before on "intro validation", and now on these.
I made the changes that you as given me!
I really appreciate your help! Thanks so much!
1@vanzasetiaPosted over 2 years ago@iagohenrique2009 You're welcome! 👍
Now, it looks better! Great job with the update! 👏
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord