Design comparison
Community feedback
- @rayaattaPosted 10 months ago
Hello πVelin Dankov, congratulations on completing this challenge π
I have two suggestion to help improve your code.
βοΈI noticed
<div class="card-head"> <div class="card-side"> <div class="card-side-box">
Divs do not carry any semantic value and therefore their usage confuses assistive technology.
It would be better if you replaced these with more Semantic alternatives like
<article>
.βοΈI noticed
html { font-size:62.5%; }
Changing the root function font size could cause Potentially huge accessibility problems for anyone who changes their default font size. I would recommend you check out this article πI hope this helps π.
I look like the fact that you made your html semantic.
Your solution is awesome π€©
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord