Grid page

Community feedback

• 

  Kadheryna•200

  @kadherynaPosted over 3 years ago

  Thank you very much for your suggestions! :)

  0
• 

  P

  Marko Nikolajević•1,065

  @MarkoNikolajevicPosted over 3 years ago

  Hi Kadheryna, you did a good job with this challenge.

  I just have a few suggestions about your code

  • looking at the report you can see that you have some issues that could be fix easily, as <title> tag that is empty or missing alt attribute in <img /> tag
  • I would suggest you to be more consistent in you sass code, for example if you started using px or rem keep on using one of these. Same for the colors, some of them are in hsl and other in rgba
  • the rgba is wrong because the last item is the alpha value and it goes from 0 to 1

  h1,
      h2 {
        color: rgba(248, 252, 253, 255); // 255 should be from 0 to 1
      }
  

  • You could wrap some elements of cards in a <div> and I think it would be easier to work with them

  • I think there too many margin on mobile view into the cards

  They are just a little fixes, overall your work is really good :)

  Keep on coding

  0