Design comparison
SolutionDesign
Solution retrospective
I really enjoyed building this project/layout it teaches a lot about grid. I really like to have feedback to that, or any suggestions if I can improve something.
Community feedback
- @jmnyaregaPosted over 3 years ago
This is amazing work @AleksandraRyan.
- You seem to have used properties that are probably cancelling each other.
grid-template-columns: repeat(4, 1fr); grid-template-columns: repeat(auto-fit, minmax(200px, 1fr));
- I think the second one will be fine since the first one will be ignored.
- This one too.
grid-gap: 1.5rem; gap: 1.5rem;
I think you can use
grid-gap
here because it has wider support.[ EDITED ]
Marked as helpful0@FarisPalayiPosted over 3 years ago@jmnyarega Nah man, it's the opposite, the first one will get ignored, and the second one will be used. for example, from this:
color: green; color: red;
Red will be shown. Or I misunderstood what you said?
1@jmnyaregaPosted over 3 years ago@FarisPalayi Yes, you are right. sorry about the confusion. ☺️
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord