Grid is the best way to solve it

Community feedback

• 

  P

  Maren Ehlers•220

  @MarenOelixtownPosted about 1 month ago

  Hey there,

  you're right, with grid you've already won a lot here.

  But there are a few things I have noticed:

  -------

  You use a lot of divs in your code. For e.g. there is no landmark like the main element, but every website should have one. One of this divs could/should the main-element.

  Here on frontendmentor I have found a helpful page with tips that clearly explain why it makes sense to have a good HTML structure 👈

  This also includes... The heading structure is unfavourable. You have mixed headings with <h2> and <h3>, but there is no clear hierarchy. If a profile name is in <h3>, there should be a higher-level heading in <h2> first.

  A clear structure supports accessibility and ensures a logical structure of the content for search engines.

  -------

  For font sizes, you should rather think about using rem (or em). You can also find a very good explanation here: Unit for fonts 👈

  -------

  If you start develope with the Mobile-First-Approach layouts tend to be very simple, making it very easy to start there. This blog-article is also worth checking out: Responsive Web Design 👈

  -------

  You did not pay much attention to the alignment of the elements in your solution. But if you go into the details again, you will certainly benefit from this.

  I hope it helps you move forward… all the best! 👋

  0