Grid, Flexbox, Sass

Community feedback

• 

  T

  Grace•30,990

  @grace-snowPosted over 3 years ago

  Hi

  This looks good but the html needs a lot of reworking to use semantic elements and fix the errors in the report. It's very important for search engines and assistive technology to use well structured semantic html - they would not be able to read this at the moment

  Also, make sure font size is in rem/em, never in px as that will not scale well for people with different zoom settings

  I recommend you read more about css specificity and reduce the nesting in your scss/css. It is a very common problem when people are first learning scss. You want to keep specificity as low as possible in css which means you should only nest selectors in scss when absolutely necessary.

  I hope this advice helps

  Marked as helpful

  0

  ---

  

  Manmohan Singh•100

  @Manmohan7Posted over 3 years ago

  Hi @grace-snow

  Thanks for taking out the time to check out the project. Regarding the semantic syntax, how can I improve it? Where can I get more practical examples rather than theoretical explanations? We can connect separately as well.

  Thanks again :)

  0

  

  T

  Grace•30,990

  @grace-snowPosted over 3 years ago

  Try and read up about it @Manmohan7

  For example, text should never be in a div or span alone, always a meaningful element. What you have as 2 headings on this project should be either one heading (my preference) or one h2 then a h3, or a h2 then a paragraph. Really try to think about the meaning of elements in your document structure.

  It takes a bit of practice but becomes automatic in time with practice

  0

  

  Manmohan Singh•100

  @Manmohan7Posted over 3 years ago

  Yup makes sense. Should have used an H3 after H2. Thanks for pointing it out.

  0
• 

  Manmohan Singh•100

  @Manmohan7Posted over 3 years ago

  Thank you palgramming 😁 Two cards in two columns sounds interesting. Will try it out and get back to you.

  0
• 

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  Without the design files you did great 🌟🌟🌟🌟🌟 if you want to challenge yourself more make a middle transitions for tablet users and small screen desktop users. The cards in two columns of two

  0