Grid, Flex, mobile-first

Community feedback

• 

  Yahia-kilany•90

  @Yahia-kilanyPosted 4 months ago

  The code is nice, using CSS variables and responsive design effectively imo. However, you should consider using the letter-spacing property on "perfume" to achieve the same effect as in the original design. it should be something like this

  .product-type{
  letter-spacing: 3px;
  }
  

  other than that I don't think I can give any other advice.

  Marked as helpful

  1

  ---

  

  DarkCityTreno•80

  @DarkCityTrenoPosted 4 months ago

  Hey @Yahia-kilany ! Thank you for your feedback, I always appreciate it, the other person commented on letter-spacing too, which is really confusing because I already had it. Thought maybe it's somehow not in github code, but it's there, just smaller amount of pixels. Anyways thank you for the comment, friend!

  0
• 

  Darkpoet•110

  @Ojay16Posted 4 months ago

  Hi there!

  Congrats on completing the challenge! ✅

  Your project looks amazing!

  I'd like to suggest a fix for a little problem u have :

  U could try using the CSS letter-spacing:; property to add spacing between the letters of the "Perfume" paragraph to give the required outcome.

  Here's a highly efficient approach:

  📌 Apply this CSS to your paragraph with the .product-type class:

  .product-type{
    letter-spacing: 5px;
  }
  

  The letter-spacing: 5px; property gives 5px of spacing between each letter, Thus giving you the desired outcome.

  Hope you find this helpful

  Happy coding!

  Marked as helpful

  1

  ---

  

  DarkCityTreno•80

  @DarkCityTrenoPosted 4 months ago

  Hey @Ojay16 ! Thank you for your feedback, I always appreciate it, the other person commented on letter-spacing too, which is really confusing because I already had it. Thought maybe it's somehow not in github code, but it's there, just smaller amount of pixels. I'll change it to 5px from 2px though, cuz it does look better. Anyways thank you for the comment, friend!

  0