Grid, Flex and HTML Studies

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hello, Marcos Rodrigues! 👋

  Nice effort on this challenge! 👏

  Like Thulani Gamteni suggested, I think it would be worth looking into making your site responsive, since it's important to change the layout of the site to accommodate different screen sizes so that as many people as possible can enjoy your work. 😉 If you'd like to learn more about responsive design, this article can help you get started. 🙂

  Besides that, I noticed that you can just a single <h1> tag for the heading of the page (since it is really just a single heading, not two separate headings). You can easily style each part of the heading differently by wrapping one of them in a <span> tag.

  Keep coding (and happy coding, too)! 😁

  Marked as helpful

  2
• Account deleted

  Looks good on desktop, from 1440px to 1120px, it all appears on the screen. Then it's not responsive until 375px. I don't think it's a good idea to have a specific device width target, as on other devices it doesn't work.

  Marked as helpful

  2
• 

  Raul A.•130

  @rarg22Posted over 3 years ago

  Nice Job! One minor improvement you could. The card color highlights, I noticed you made a <div> element for those and shaped them according but they don't look too smooth and give you an extra DOM element. Instead, you can try using pseudo-elements ::before or ::after. You can play with those instead to avoid creating an extra DOM element. You can probably position them at the top of the card and then use overflow: hidden to make it follow the shape of the card and make it look smoother.

  Marked as helpful

  1