@nohawaheed
Posted
Hello @pr0g4ng3l,
Great job on completing the challenge!
Your design for both large and small screens looks fantastic. I have a few tips to help improve your code.
Instead of giving fixed heights like .full-section { height: 65vh;}
consider using min-height: 100%;
which allows the element to dynamically adjust its height based on the content within it or the height of its parent container.
Additionally, you could use margin: auto;
instead of using position: absolute and transform to center content.
Position absolute is commonly used for elements that need to be positioned in a specific location on the page, such as overlays, tooltips, or dropdown menus.
If you choose to remove the position, make sure to also remove the top property in .attribution { top: 90vh; }
I suggest checking out Frontendmentor's learning path on Building responsive layouts if you haven't already. It provides excellent resources to help you develop responsive layouts.
hope this helps!
Marked as helpful
@ponkydev
Posted
Thanks for your advices! I really appreciate them! @nohawaheed
@nohawaheed
Posted
@pr0g4ng3l I'm so glad it was helpful!