Design comparison
Solution retrospective
Still trying to figure out when and how to properly nest styles with scss
Community feedback
- @mattstuddertPosted almost 5 years ago
Awesome work on this challenge! I'd recommend removing the
height: 100vh;
from thebody
on mobile, as it's currently cutting off the content at the bottom.What is it about nesting in SCSS that you're having issues with?
0@vongphakdyPosted almost 5 years ago@mattstuddert I was wondering why that cutoff was happening. Forgot to remove the height style from an earlier method I was trying out. My nesting concerns with SCSS is based on lowering specificity and knowing when you would want to nest. Since posting my solution I've read up on SMACSS (http://smacss.com/ suggestions so I'm going to apply those practices to my next challenge.
0@mattstuddertPosted almost 5 years ago@vongphakdy nice, yeah SMACSS is a great methodology. As a general rule of thumb for nesting, I would try to never go more than 4 levels deep. Also, avoid unnecessary nesting wherever possible.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord