Design comparison
SolutionDesign
Solution retrospective
I did it from Brad Traversy's Grid Course
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some recommendations for enhancing your code.:
- ALWAYS check ⚠️ your FEM report as it is the first of feedbacks that you receive on what you need to improve upon. This should be done immediately after submitting your challenge.
- For the testimonials, it is best ✅ to to wrap each individual testimonial component in a
figure
element, the individuals information should be wrapped in afigcaption
element and lastly, the testimonial itself should be wrapped in ablockquote
element.
Code:
<figure> <figcaption></figcaption> <blockquote></blockquote> </figure>
More Info:📚
- The profile images are not decorative ❌. Their
alt tag
should not be blank. It should state the person’s full name.
More Info:📚
- ALWAYS Implement a "Mobile First" approach 📱 > 🖥
Mobile devices are now the dominant 👑 way in which people browse the web, it is critical that your website/content looks perfect 💯 on all mobile devices.
More Info: 📚
- For improved accessibility 📈 for your content, it is best practice ✅ to use
rem
for yourfont-size
and other property values. Whileem
is best formedia-queries
. Using these units gives users the ability to scale elements up and down, relative to a set value.
If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.
Happy Coding! 👾
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord