grid and media-queries

Community feedback

• 

  Adriano•38,080

  @AdrianoEscarabotePosted about 2 years ago

  Hi Ahmed, how are you?

  I really liked the result of your project, but I have some tips that I think you will like:

  1- Heading levels should only increase by one click here

  I noticed that you made a button using div, an advice I give you is to use the button element that would make the code more semantic, and to improve even more add an aria-label explaining the button function.

  The rest is really good! Congratulations on the evolution. Hope it helps... 👍

  Marked as helpful

  0

  ---

  

  Ahmed•150

  @Ahmed-Elsayed-projectsPosted about 2 years ago

  Hello @AdrianoEscarabote, I really appreciate your feedback, the reason why I increased headings by more than one is because I was trying to match the design. Anyway, thank you again for your feedback

  0

  

  Adriano•38,080

  @AdrianoEscarabotePosted about 2 years ago

  @Ahmed-Elsayed-projects no problem, keep coding!

  0