Design comparison
Solution retrospective
All comments are welcome! Grid and Grids / No JS / have not learn JS yet. More focus in HTML and CSS.
Community feedback
- @zebokPosted over 3 years ago
Hey Tony! Well done mate! The layout looks good. Congrats!
Try using the correct HTML elements.
There are some semantic HTML elements (specifics) (<article>, <main>, <footer>, <section>, etc) And! Non semantic HTMl elements (non specifics) ( <div> <span>)Try using them corectly. This is very useful. Semantic element describes its meaning to both developer and browser.
I can see you have used the <article> HTML element for just a paragraph. In that case, you should use the <p> HTML element.
You have also used <section> HTML element inside a <div>. This is weird. Usually we use the <section> HTML element precisely for that, a section. Inside this <section> you can have articles, divs, h1/h2..., paragraphs, forms, etc.
Michelle Appleton 28 jun 2020
This is not an article, this should be a div. With 2 <p> tags, or maybe one heading and one <p> tag.
Try using the correct HTML elements. Think about it. Ask yourself. What is this? It is.. an article? O maybe its a list? Help the browser understand.
If you cant define what it is with a semantic HTML element, then use a div or a span.
Hope you understand me! Keep practising mate! Keep going! Some day, we will we experts doing this! Cheers!
Marked as helpful1 - @tony1610Posted over 3 years ago
Sebastian, Thanks for the comments, for some reason in my mind I think that using a "div" is just for a whole section. For sure, I will put more attention to this details, te create a more semantic markup.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord