T
Matt Studdert• 13,611
@mattstuddert
Posted
Hey Samy, nice work on this challenge! It's great to see you asking very specific questions. I've taken a look at your project and here are my answers:
- The only thing I'd review for accessibility purposes would be the email
input. I'd change thetitleattribute toaria-label. This ensures that the value of that attribute is read out by screen readers. Otherwise, they'll typically read out the placeholder text which wouldn't be very helpful. - Your naming is fine. It will come with time but there are techniques out there that you might find useful. For example, I'd recommend looking into BEM naming conventions. A lot of developers use it and it works well.
- Everything looks great on a larger screen, so you've done a great job with this.
I hope that helps. Keep up the great work!
1
Samy• 85
@anaiel
Posted
Thanks for the review! I used the title attribute after reading this page: https://www.w3.org/TR/WCAG20-TECHS/H65.html but I'll admit I don't know much about aria attributes yet so I'll look into it. I'll also make sure to check out BEM naming conventions.
0
T
Matt Studdert• 13,611
@mattstuddert
Posted
@anaiel ah OK. My screen reader still read out the placeholder text. I'd stick with aria-label anyway just to be sure. Aria attributes are definitely worth looking into 👍
1
