
Design comparison
Solution retrospective
as much as possible i try to design the real solution for desktop and mobile devise
What challenges did you encounter, and how did you overcome them?to be scale the real design
What specific areas of your project would you like help with?using the precise mesurement for padding ,margins ,font-size , font-weight
Community feedback
- @rkrhlikarPosted 2 months ago
I love the fact that you personalized the page a bit by using (I assume) your own name and location! :)
It's nice to see the alt text set correctly (i.e. empty) for decorative images.
Are you developing on a mobile device by any chance? I see that the mobile version of the site is a lot closer to the reference. I think that most (if not all) of the sizes are just a bit too small on the desktop version, making it very hard to read. You can look at the automatic screenshot to get a sense of what it looks like on a desktop device.
A couple of other things I noticed that might be helpful:
- As this is a list of links, using
a
for the buttons instead ofdiv
would probably be a better choice. - On smaller devices you set the
width
of.container
to280px
which leaves white bands on either side of the screen if the screen is wider than that. You can work around this by either getting rid of the explicit setting ofwidth
altogether (from what I can tell that doesn't break anything) or by setting thebackground-color
onbody
to match thebackground-color
of.container
(currently it is set towhite
by default which is what is visible on the sides). - There are a couple of values that are repeated multiple times in the CSS - you can use CSS variables for those (e.g. a color that is used in multiple places).
I hope that these tips are helpful.
If you want to get values for the sizes (e.g. font size, paddings, etc.) you can take a look at my stylesheet for this solution. I can't guarantee that all of the values are correct, but they represent my best guesstimate and seem to match pretty well with the reference images.
If you are developing on a mobile device, hats off to you. This is very nice and better than what I could do using a small mobile device! :)
0@KalSol12Posted 2 months ago@rkrhlikar thank you so much i would correct it and i see you solution that good i would take some of your code that lovely
0 - As this is a list of links, using
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord