@KrishnaVishwakarma1595
Posted
Hi, @AmrAbdelgwaad
Congratulations on completing this wonderful challenge. Your solution looks really great.
I've some improvement points for you -
-
You can autofocus the input field by default, so the user does not need to focus manually initially.
-
As the input is required it shows the browser default require message. You can also provide your custom one.
-
After the successful search, you can clear the input so the user does not need to clear it manually again and again.
-
When no result is found, even when we clear the input the text "No results" still showing. Instead, you can hide it as well on clear input.
-
On click of the theme switch the theme switches so fast which feels a bit odd in the eyes. You can give a bit of a transition effect like below so that it'll be smooth and nice looking.
transition: all .3s linear
I hope these points will help you. Great solution.
Happy Coding
Marked as helpful
