Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

GitHub user search app(React, Styled-components)

lsh 160

@SH-Lee2

Desktop design screenshot for the GitHub user search app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello everyone, finally! I finished the project. But I'm not sure if the way I did it is correct. In particular, it was too difficult to do responsive design. If there is something strange, please feel free to tell me!

Community feedback

Joanna 370

@JoannaLapa

Posted

Hi LSH,

My congratulations on finishing the project! I can find users and I see all the needed information correctly. I can switch between dark and light mode, it works. Good job!

Some details that you can improve:

Concerning main functionality:

  1. Website, Twitter, and company information should all be linked to those resources. On the website there is a mistake - it tries to join https://gitgithub-user-search-app.netlify.app/ and the user's website address, then when I try to open the resource the page is not found. Twitter and company information aren't linked to their resources (and there isn't a cursor pointer).

  2. When I click on the button and the input value is empty there should be an error 'No results'

  3. When I try to find a user by his full name with spaces (like Joanna Łapa) I see an error - you can resolve this case if you split the input value using the following methods: .value.split(' ').join(''). If this is not clear you can see it here with my solution

Some very small design details if you would like to improve:

  1. Your h1 has a typo (it should be devfinder instead of debfinder).

  2. Your search icon is smaller than the original version.

  3. I feel the impression that the font-family Mono Space doesn't work on the username (h1).

  4. A hover on the button doesn't work.

I hope that my feedback was helpful! Happy coding! Joanna

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord