GitHub User Search app with Sass, JS, CSS Grid, Flexbox and Parcel

Community feedback

• 

  Dharmik_487•1,740

  @Dharmik48Posted about 3 years ago

  Hey👋,

  Good job with the solution! But there a some issues you can fix:

  • Maybe remove the default outline from input and button when focused.
  • And when the page first loads the data is empty so maybe you can add a default profile of someone which is there on first load

  Apart from these it is really good, keep it up👍

  Marked as helpful

  3

  ---

  

  Dmitry•375

  @dmitrymitenkoffPosted about 3 years ago

  @Dharmik48 Thanks for your feedback. I've added the focus styles manually (autofocus on input) for accessibility reasons, although i realise these are not part of the provided design files. I'll play with these styles more and see if any other outline styles might look better! Cheers!

  0