GitHub user search app with Sass

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hello, Miguel Zapata! 👋

  Regarding the way you fetch the API, I think you can simplify it by grouping the error handling and the response as one function. After that, you can make that function returns the JSON data.

  const fetchUserData = async (username) => {
    try {
      const response = await fetch(`https://api.github.com/users/${username}`);
      const json = await response.json();
      /* do something with the json */
    } catch (error) {
      /* handle error */
    }
  }
  

  Some more suggestions.

  • The moon and the sun icons are decorative images. So, I recommend adding aria-hidden="true" and focusable="false" attributes to the svg. This way, those icons will be hidden from the screenreader users.
  • I recommend using hidden attribute instead of using .hidden class.
  • Always specify the type of the button. In this case, set the type of them as type="submit". It will prevent the button from behaving unexpectedly.
  • Location is just plain text (not a link).
  • If you want to make the company as plain text then I recommend swapping the anchor tag with span instead. Assistive technology might still pronounce it as a link (even without the href attribute).

  That's it! I hope you find this useful!

  Marked as helpful

  1
• 

  Chris•240

  @ChristopherParkePosted over 2 years ago

  Looks good. My only note would be that yes the API fetch works, but it would be better in a framework like React or Vue. That's because it would be more portable and easier for others to understand and use your code. Great work though. Basically perfect.

  Marked as helpful

  1