Skip to content
Submitted about 3 years ago

GitHub user search app solution

Natallia Dzemiashkevich•395
@natalliasdh
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...GitHub user search app
  • HTML
  • CSS
  • JS
  • API
2junior

Design comparison

SolutionDesign

Community feedback

  • Chamu•13,150
    @ChamuMutezvaPosted about 3 years ago

    Congratulations for taking and finishing this challenge. Well done the functionalities are working as expected as well as the presentation. Here are some few suggestions:

    • i see the body has this <body class="dark-theme||light-theme">, and yet dark-theme and light-theme is being added again separately when i toggle the div. Well it really doesn't change the working of the app, unless i am missing something then i would suggest removing it.
    • semantic elements matters as that will make your site accessible without adding additional coding. The following div which is acting as a button is not accessible to assistive tech users - it will require a lot more additional html and javascript code to make it available to Assistive tech users
     <div class="mode">
                <div id="color">Dark</div>
                <div><img src="assets/images/icon-moon.svg" alt="Dark mode" id="coloricon"></div>
            </div>

    you can use a button, eg

     <button class="mode">
                <span id="color">Dark</span>
                <img src="assets/images/icon-moon.svg" 
                  alt="Dark mode"       id="coloricon">
 </button>
    • an input element must have a label <input type="text" id="searchfield" placeholder="Search GitHub username...">
    • try navigating using a keyboard and see if you can tell where your current focus will be. If you remove the outline on focusable elements you need to somehow customize it .
    Marked as helpful
    1
    Natallia Dzemiashkevich•395
    @natalliasdhPosted about 3 years ago

    @ChamuMutezva, thank you very much!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord