Github user search app - plain HTML/CSS/JS

Community feedback

• 

  Elyas•300

  @ElyasthrPosted almost 3 years ago

  Perfect job & great initiative !

  Marked as helpful

  0

  ---

  

  Ambre•170

  @Yunie08Posted almost 3 years ago

  Thank you @Elyasthr !

  0
• 

  Rosi•440

  @strosiPosted almost 3 years ago

  It works like a charm for me and the code looks very clean :)

  1

  ---

  

  Ambre•170

  @Yunie08Posted almost 3 years ago

  @strosi Thank you for your nice feedback ^^

  0
• 

  Vanza Setia•27,775

  @vanzasetiaPosted about 2 years ago

  Hi, Ambre! 👋

  Congratulations on completing this challenge! 🎉

  I searched my own profile and I didn't see any issue. Good job! 👍

  Here are some recommendations for improvements.

  • I would recommend using the Date() object to format the date. This way, you can get the date easily by using some methods. For example, to get the month index number, just use getMonth() method.
  • I would recommend using hidden attribute instead .hidden styling if possible. It is a little bit easier to use the hidden than to create a hidden styling.
  • For the statistic, I would recommend using a list element. Also, the user-info__stats__title should be a span instead of h3. I highly recommend reading the "How-to: Accessible heading structure - The A11Y Project" article to learn more about headings. If the site has no styling then it will look something like this.
    • Repos 8
    • Followers 3938
    • Following 9

  That's it! I hope this helps! 🙂

  0