Github User Search App

Community feedback

• 

  Jason Moody•300

  @MoodyJWPosted over 2 years ago

  Hi Thiago! Great job on the challenge! I noticed a styling issue in the section with location, twitter, etc. If the content is longer it will overflow the container and cover the second column.

  Here's a screenshot of what I'm talking about

  You can probably fix this with some relatively simple CSS on the element containing the text

  text-overflow: ellipsis;
  overflow: hidden;
  width: 100%;
  

  As long as the parent element has a width, the text should cut off at the edge of the parent element. You might need to adjust that width based on how you've set up the flex boxes.

  I'd also suggest trying to start developing for mobile first, it makes styles a lot easier to adjust when you're getting bigger instead of smaller. Plus over 90% of people in the world access the internet via mobile, so most frontend work is going to require responsive styles. Still, this looks really good and the small change to the text should make the desktop version perfect! Hope this helps, let me know if you need more info.

  Marked as helpful

  0

  ---

  

  Thiago Santos•330

  @tssantosPosted over 2 years ago

  @MoodyJW Thanks for your comments! I'm going to take a look at suggested points.

  1