Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Github User Search App in Vanilla JS

Amr Emara 40

@aemara

Desktop design screenshot for the GitHub user search app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Feedback is appreciated.

Community feedback

@MarlonPassos-git

Posted

hello Amr Emara congratulations for having completed your 5th FEM challenge, I liked your solution, it was very functional and similar to the original version. Now some suggestions for you to improve your project

  • I would put the user's theme state saved in Local Storage, it's kind of annoying when we refresh the screen and go back to the original theme

  • I would put "toggle-theme" as a button, as it is inaccessible using only the keyboard

  • location could be inside an <adress> tag

  • It would make the entire panel more centralized to look more like the original version

  • in the panel size you could have simply set the max-width, min-width and width to some percentage that wouldn't even need @media to make the layout responsive

  • I saw that there are some things in your report, you'd better take a look,

  • It's nice to put at least one print of your project on the git gub, it makes things prettier 😁

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord