Github user search app (Html,Css(Sass),Js,API)

Community feedback

• 

  Matt West•440

  @matt-o-westPosted 10 months ago

  Hello! Thank you for your submission! I have some feedback for you:

  • In your input, you've added an onclick event listener. While this is fine, it can improve the user experience (and is best practice) if you code this as form with an onsubmit. When the form is submitted, you perform the same callback function.
  • Your theme is toggling correctly, but the UI isn't updating the string label for the theme button (i.e. it always says 'Light' regardless of the current state). It should be a simple fix, adding into your toggle function to update the text inside that node when the theme toggles.
  • Responsiveness is looking good, although your placeholder text is crashing with error messages in mobile when they appear. You might need to put the error message above or below the input on mobile.

  Above all, the solution you submitted is great and you should be proud! Great work! 🎉

  Marked as helpful

  1

  ---

  

  P

  Pablo Dettori•740

  @p4bloxxPosted 9 months ago

  hi @matt-o-west and thank you very much for your feedback ;) regarding the light/dark toggle label I didn't really notice the error even though I looked at it several times... regarding the other two errors I thank you, I should have looked again and try everything again in more detail...my mistake. I'm happy that overall you liked it as a solution, see you next time and thanks again ;)

  0