Skip to content
Submitted over 2 years ago

Github search app using React & Styled Components

David•8,000
@DavidMorgade
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...GitHub user search app
  • HTML
  • CSS
  • JS
  • API
2junior

Design comparison

SolutionDesign

Solution retrospective

Hello and welcome to my Github search app solution

For further details, get a quick look into my readme.md

For me this was more of an Intermediate challenge and not a Junior one!

  • Build using React & Styled components with Styled components Theming.

  • Fetched data using fetch() function.

Questions

What do you think about the Placeholder?

Should I have define a span instead to get a better solution instead of placeholder

Looking for testing to see if it's working properly!, also all feedback is welcome.

Community feedback

  • Babacar Ciss•460
    @Babacar-CissPosted over 2 years ago

    hi that's very nice !!! that's will be interested if you could add some loading between fetching and displaying result

    1
    David•8,000
    @DavidMorgadePosted over 2 years ago

    @Babacar-Ciss Hey man thanks for your feedback!

    I added a little loading spinner animation when the data is fetching!

    0
    Babacar Ciss•460
    @Babacar-CissPosted over 2 years ago

    @DavidMorgade great !!! just one more remark the default theme mode should depend on your setting default setting !!! sorry for the English i am a french speaker !

    1
    David•8,000
    @DavidMorgadePosted over 2 years ago

    @Babacar-Ciss Thanks for the advice!, Added.

    Now the first time you log in you get the default mode depending on your browsers options, if changed it gets the value from localstorage!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord