Skip to content
Submitted almost 3 years ago

Github search app

Nicholas•235
@fytrw
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...GitHub user search app
  • HTML
  • CSS
  • JS
  • API
2junior

Design comparison

SolutionDesign

Solution retrospective

Hi!👋

Here is my API Junior project! I hope I have done well. Icons don't work well, I'll improve it(i think changing to SVG can help). Also, I have to improve the website link. If you see any flaws let me know. I'll do this project again in react.

It will be great to hear some feedback from you!

Community feedback

  • Rio Cantre•9,690
    @RioCantrePosted almost 3 years ago

    Hello there! Awesome work with this one. Looking at your solution, I would like to suggest the following for you...

    • Wrap the whole content with specific tag like main. For HTML structure, refer it with this one Semantics
    • Include description with the alt in img tags
    • Modify the margin in .search-icon rule set into margin: 0 24px

    Above all, the project is looking great! Hope this helps and Keep it up!

    Marked as helpful
    0
    Nicholas•235
    @fytrwPosted almost 3 years ago

    @RioCantre Thanks a lot!

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord