@SergioCasCeb
Posted
Overall really good job, and I like the extra animation you added to the card on hover, but there are a few things you could use to improve it.
- Your spacing is a bit of from the design guidelines given in the Figma files.
- You should not use the main element for you component, as that is not a good practice and should be used as the overarching parent of you content.
- Since your hover is on the card, you didn't specify any behavior on focus and you font have any interactive element in your card title like and <a> element the focus behavior of course doesn't work.
- Also you might be overdoing it with the HTML tags.
1
Jorge• 40
@Broderpixelv1
Posted
@SergioCasCeb *
I agree with everything, I am putting into practice what I am learning and I try to apply them in each exercise so as not to forget them, so yes, I am exaggerating.
The <main> thing is correct, I'm going to replace it with a <section>, since after all, it is a card, it is a component of a page.
In the animation I followed the animation of the prototype in figma in the title and the card, but, I am going to put a cursor: pointer; in the title.
Thank you very much for the feedback, it helps me a lot.
0
