Getting to practice more flexbox and media queries.

Community feedback

• 

  T

  Grace•31,230

  @grace-snowPosted about 3 years ago

  Hello

  I have suggested improvements for your html

  • remove all brs. Use css to create block context of margins. Brs will get read out my screen readers and are not what this is for
  • remove the alt text on images, or rewrite it in the first one to make it a meaningful description of the image. If images are decorative (not meaningful content) they should have alt=“”
  • make annual plan a h2
  • swap the buttons and anchor links. Change seems like it would toggle the price (perform an action) so should be a button. “Proceed” and “cancel” sound like they will navigate users forward or back, so should be anchor tags

  CSS looks really good 👍

  Only suggestions are:

  • make sure all interactive elements always have focus-visible styles so keyboard users know where they are on the page. Very important.
  • next time work mobile first, and use a min-width media query

  I hope that helps

  Marked as helpful

  1

  ---

  

  Juan Lorenzo Reyes Silva•30

  @EnzoReySilPosted about 3 years ago

  @grace-snow thanks! I will improve it today following your advice.

  0