Galleria slideshow site with masonry style layout

Community feedback

• 

  alexander•1,300

  @alex931dPosted 8 months ago

  Great solution; however, I noticed a minor mistake :) You haven't implemented the slideshow functionality as shown in the design. The slideshow is supposed to have a progress bar that slides to the next page over time, which I didn't see myself.

  Secondly, I find it worrying that when I click fullscreen on an image, it takes up more space than available on my screen, causing me to scroll. Another issue I encountered is that clicking outside the popup modal does not close the image!

  Thirdly, it would be nice if instead of opening a separate page for each slideshow, you could have an ID on each portrait and create a universal solution. This is not only good for SEO but should be best practice. You could do something like slideshow?id=1 example to refer to which image has been clicked on.

  Another thing I noticed is how you haven't implemented the data.json file to fetch the data, but you manually use HTML elements instead. This is not only horrible but very wrong. And I suggest you take an easier challenge if these ones are too hard; if, for example, a potential job interviewer were to see your code, they would run away immediately. I hope you will understand my points made and learn from them other then that have a great day!

  Marked as helpful

  0

  ---

  

  P

  agnese•360

  @aggie-lPosted 8 months ago

  @alex931d thank you for taking time to comment on my solution, your feedback is greatly appreciated and really helpful.

  1

  

  alexander•1,300

  @alex931dPosted 8 months ago

  @aggie-l Great! im excited to see you improve :)

  0