Galleria slideshow site using React

Community feedback

• 

  P

  Kamran Kiani•1,540

  @kaamiikPosted 24 days ago

  Hi. Congrats for doing this challenge. Your animations really beautiful. I really liked them. Also I noticed some points I wanna mention:

  • In your details page inside your header the Galleria logo should be a link and also need a visually hidden text for screen readers . you can use h1 inside your main tag.

  • Your max-width should be in rem unit.

  • For the painting and the headings near to it and also the avatar image you can simply use grid layout for 3 screen sizes. There is no need to use absolute positioning. Just work on the grid-template-rows and grid-template-columns and then you can delete lots of your CSS code on absolute positioning.

  • The Year is not a heading I think. using p is better or you can use ::before for the description and add the year.

  • All of your content should be inside the main element.

  Marked as helpful

  0