Design comparison
Solution retrospective
Let me know how the website came out. Took a while but I think I got it to a good state! I added text to speech so you can listen.
Community feedback
- @MarlonPassos-gitPosted about 3 years ago
I really liked its very flexible and smooth implementation.
Some suggestions:
-
When I click on the Wikipedia link, and then use the browser's back button to your 404 error page https://prnt.sc/1vp648o, it would be nice for you to solve this, many users do this type of navigation
-
Instead of the images breaking from 2 columns to 4 direct columns, it would be nice to break down to 3 columns as well,
-
It would be nice to add some keyboard commands, arrows to switch images, ESC to go back to menu, ENTER or SPACE to open image, this always brings a good experience for the user.
-
I could be wrong, but I think when we click on "start slide show" it should make the images change themselves, if not blz, but that would be something cool would be 😁
-
menu-container could be in a <header> tag and galleria-container could be in <main> and slide-show-playlist could be a <footer>
-
close and view the images should be a button to be accessible to the keyboard
-
Instead of creating a div for each element you could have left all the elements loose and atomically they would be organized by some more advanced properties of grid or flex. I would recommend you research how pinterest organizes its images
2 -
- @mrcastilloPosted about 3 years ago
Appreciate that you took the time to look at the project and give me some very great feedback. A lot of these suggestions gave me a "of course" moments and also gave me new challenges for this. I will definitely need to get out of the habit of using DIVs and make my HTML be more semantic to have tags have more representation. One thing I would like to mention is that the images do switch by themselves on "start slide show" after text to speech is completed, but the slideshow stops if you scroll. I wanted to have the slideshow be passive and user be able to stop it easily especially since it has voice. I will take another look at this project soon, thank you so much for the feedback.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord