fylo-landing-page

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hi Atharva Hinge,

  Excellent work! I have some suggestions regarding your solution if you don't mind:

  • Bad value for attribute `srcset` on element `img`. So remove this attributes from all the<img> ``tags in the document.

  • You should use <main> landmark to wrap the body main content.

  • The alternate text of the logo should not be empty, you may set alt=”Fylo". Use the website's name as an alternate text. Remember that a website-logo is one of the most meaningful images on a site so use proper alt for it.

  • If you are going to leave the logo not wrapped by <a>, it’s better to place it out the <nav> as it does not navigate the user in anywhere (only an image).

  • Forms with proper inputs and labels are much easier for people to use. To pair the label and input, one way is An explicit label’s for attribute value must match its input’s id value. Input fields without accompanying labels can lead to accessibility issues for those who rely on screen readers. If a screen reader comes across an input field without a label it will try to find some accompanying text to use as the label.

  • A button with no type attribute acts as type=”submit”, and will attempt to submit form data when clicked. Be explicit in your intentions and provide a type. By specifying either button, submit or reset, the code’s purpose is clear and is easier to maintain. For the first form, the button's type is not specified, but in the second is.

  In class="right-text", you should use <form> instead of generic div.

  • You should use the<nav > landmark to wrap the footer navigation. Then you should add aria-label=”secondary “ or aria-label=”footer” to it. A brief description of the purpose of the navigation, omitting the term "navigation", as the screen reader will read both the role and the contents of the label.

  • Thenavelement in the header could use an aria-label="primary" or aria-label=”main” attribute on it. The reason for this is that, you should add the aria-label for a nav element if you are using the nav more than once on the page.You can read more in MDN

  • In .information , you may use <address> tag to wrap the contact information class="first-col" for the author/owner of a document or an article (email and phone number). By adding semantic tags to your document, you provide additional information about the document, which aids in communication.

  • You should wrap the list items in the footer by a link <a href="#">About us</a>, in this instance, it does not navigate the user anywhere.

  • You should use <a> to wrap the social icons. The social links wrapping the icons must have aria-label or sr-only text indicate where the link will take the user. Then you set aria-hidden =”true” to the icons to be ignored by assistive technology .

  Hopefully this feedback helps.

  0