Design comparison
Solution retrospective
Please don't hesitate to correct my mistakes to help improve my skils.
Thank you.
Community feedback
- @elroytoscanoPosted almost 3 years ago
Good job at the pixel perfect design. You can improve the visual design by using
cursor:pointer
for your buttons as that would provide visual feedback to the user.For your HTML issues, keep only 1
h1
in each page as it is accessed by screen readers. All the other headings should repeat in ascending order. In your footer, you've used divs with classes "about" and "contact", instead use only unordered list,ul
and each item should be placed in a list-itemli
. The footer links are "links", i.e.a
and notp
elements, as they are used to navigate to that page/section.Hope this helps.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord