Fylo-data-storage-component-using-ScSS

Community feedback

• 

  Marcos Travaglini•4,840

  @BlackpachamamePosted 11 months ago

  Greetings! you have done a great job 😎

  I want to make some suggestions to you:

  • In your storage-systems you can place your img in containers, to these you give the same values that you placed to the images and some more. This will prevent the images from stretching:

  HTML 💀

  <div class="storage-systems">
    <div class="container-img">
      <img src="./images/icon-document.svg" alt="">
    </div>
    <div class="container-img">
      <img src="./images/icon-folder.svg" alt="">
    </div>
    <div class="container-img">
      <img src="./images/icon-upload.svg" alt="">
    </div>
  </div>
  

  CSS 🎨

  .container-img {
      background: hsl(229, 57%, 11%);
      width: 44px;
      height: 44px;
      border-radius: 8px;
      cursor: pointer;
      display: flex;
      align-items: center;
      justify-content: center;
  }
  

  • I don't understand the min-height: 700px in the body for @media (min-width: 600px). What do you achieve with this?
  • The slider always looks blue, it should take on another color

  The rest looks good, well done!

  Marked as helpful

  0

  ---

  

  Viki Wainaina•410

  @CSS-VikiPosted 11 months ago

  @Blackpachamame Thank you my friend for the tips, I hope we even get to work with one another because being self taught, i need someone else's perspective and opinion💪🏽💯. -> For the min-height you asked, it was to make the bg desktop image appear at the center like the design files (kind of a rat tactic😂) but i will try to find another way to do it. -> Finally for this issue (The slider always looks blue, it should take on another color), in my local deploy everything is okay, because when you check my screenshot on github, the slider range progress takes the colour thats given in the files. I do not know if its a browser issue or something else

  1

  

  Marcos Travaglini•4,840

  @BlackpachamamePosted 11 months ago

  @CSS-Viki I think I know why I don't see it, it doesn't seem to work for all users. More info. I can't think of, at this moment, any other way to do it without using that selector.

  For this:

  For the min-height you asked, it was to make the bg desktop image appear at the center like the design files (kind of a rat tactic😂) but i will try to find another way to do it.
  

  You can leave the min-height: 100vh instead of changing it with the media query, at least on my pc it looks good

  Marked as helpful

  1

  

  Viki Wainaina•410

  @CSS-VikiPosted 11 months ago

  @Blackpachamame Okay will do my friend💪🏽💪🏽. Thanks!!

  1