fylo-data-storage-component-master

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted 7 months ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have a suggestion regarding your code that I believe will be of great interest to you.

  ---

  MAKING BUTTONS ACCESSIBLE :

  • The icon elements are needed to be button elements, because using 'div` elements is not a good practice.

  ---

  <div class="icon">
       <img src="images/icon-document.svg" alt="">
  </div>
  

  • Even if we style them to look like button, we still not properly structured them in markup. So we need to tell the accessibility devices about what the button is used for using aria-label attribute.

  ---

  • Here's an Example:

  <button class="icon" aria-label="Click to Upload your files">
       <img src="images/icon-upload.svg" alt="">
  </button>
  

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1